Install4j configuration #95
Conversation
kayyagari
requested review from
gibson9583,
ssrowe,
kpalang,
jonbartels,
tonygermano and
pacmano1
|
The generated installers:
|
| @@ -4,7 +4,7 @@ | |||
| -include-options conf/base_includes.vmoptions | |||
|
|
|||
| # Comment out the following line if you are running on Java 8 | |||
| -include-options conf/default_modules.vmoptions | |||
| #-include-options conf/default_modules.vmoptions | |||
There was a problem hiding this comment.
Java 8 should not be the default option.
| @@ -4,7 +4,7 @@ | |||
| -include-options conf/base_includes.vmoptions | |||
|
|
|||
| # Comment out the following line if you are running on Java 8 | |||
| -include-options conf/default_modules.vmoptions | |||
| #-include-options conf/default_modules.vmoptions | |||
There was a problem hiding this comment.
Java 8 should not be the default option.
There was a problem hiding this comment.
My thinking here is that, we say v4.5.3 is compatible with Java8 but it doesn't run with Java8 unless user modifies this file after installation.
If we decide Java8 should not be the default option then I can make the minimum required version to 9 in install4j configuration.
There was a problem hiding this comment.
I'm not sure how this translates to install4j options, but java 8 is the minimum version to run the server. I think there was consensus that java 17 should be the recommended and default. I would say the latest LTS release, but I don't know how well we've tested it on java 21. Java 17 has been what is used in the NG docker containers for the past couple years, so we know that's well tested.
There was a problem hiding this comment.
Right now Install4j is configured to not create new vmoptions files and the existing vmoptions files are the ones used by oieserver and oieservice.
These lines will be uncommented once we update to a version >= java 9, which I think will be likely in OIE v4.5.4 (or any other that comes after current 4.5.3).
There was a problem hiding this comment.
The lines should be uncommented in the repo and packages always, by design. It should work without changes for those running java 9+. The users running java 8 will need to comment the line out themselves post-installation.
LICENSE
Outdated
| Copyright (c) 2025 Open Integration Engine Contributors. Visit https://openintegrationengine.org/ | ||
|
|
||
| https://www.nextgen.com/products-and-services/integration-engine | ||
| Copyright (c) 2005-2024 NextGen Healthcare. |
There was a problem hiding this comment.
I think the copyright information can be removed from the license completely so that it is just a clean copy of the MPL 2.0 license. The main place that copyright info should be specified (and it already is, in most cases) is the header on each file.
There is other MPL licensed software (like Rhino) which ships with the software and is not copyright NextGen or OIE contributors.
| <variables> | ||
| <variable name="installer:mediaRoot" value="/Users/dbugger/projects/engine" /> | ||
| </variables> | ||
| <jreBundles jdkProviderId="Zulu" release="8/8u452"> |
There was a problem hiding this comment.
I was against bundling a JVM as it makes the download much larger, and people may not even want to use the bundled version, but if we're going to include one, I think it should be java 17.
There was a problem hiding this comment.
This config is for the installation binary to run, not for bundling with the binary.
Signed-off-by: kayyagari <kiran@sereen.io>
…oieservice during uninstallation
kayyagari
force-pushed
the
feature/install4j-config-81
branch
from
684bbb8 to
7247f5b
Compare
- Added library java-semver-0.10.2.jar for version parsing and comparison. - Refactored to use streams and added tests - No longer calls a self-hosted service, so active extensions are no longer provided as part of the request. Co-authored-by: Richard Ogin <rogin@users.noreply.github.com> Co-authored-by: Jon Bartels <jon.bartels@teladochealth.com> Co-authored-by: Tony Germano <tony@germano.name> Signed-off-by: kelaompachai <141376761+kelaompachai@users.noreply.github.com> Signed-off-by: Richard Ogin <rogin@users.noreply.github.com> Signed-off-by: Tony Germano <tony@germano.name> Issue: #24
Adds the following settings to BrandingConstants in client-core: - CENTRAL_USER_REGISTRATION - When false, disables the sending of user demographic information and hides the registration and marketing consent boxes from the first time login screen. - MANDATORY_USER_REGISTRATION - used in conjunction with CENTRAL_USER_REGISTRATION. When this is setting is true and the user id is 1, then the user will not be able to unselect the registration checkbox. - CHECK_FOR_NOTIFICATIONS - When false, allows for notification fetching from the client to be disabled. The notification menu task is also removed. - SEND_USAGE_STATISTICS - When false, allows for sending of usage statistics to be disabled. Also hides the setting which allows users to opt-in or opt-out of sending statistics. With the restoration of the registration checkbox when the appropriate settings are enabled, the adjustment of which fields are required on the user profile has also been restored. Co-authored-by: Tony Germano <tony@germano.name> Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net> Signed-off-by: Tony Germano <tony@germano.name> Issue: #5
I have commented out the line that included modules to make the binary start with Java8 by default(because our first release still targets Java8) , let me know if there are any objection to that.