Procedurally generate Arrays.sol

[RenanSouza2]

This PR creates scripts to generate the Arrays.sol file,

It also includes tests for unsafeMemoryAccess functions

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: c6c3bb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[RenanSouza2]

Hey,

Are you interested in adding a function for bytes32 memory array?

There are lots of simplifications that can be done if there are the same functions for both array and storage

[Amxx]

Hello @RenanSouza2

We have multiple PR targetting Array.sol. #4846, #4842. I'm not sure we need to generate this file procedurally. I'd delay that decision until after the above PR are processed.

[ernestognw]

I made a few adjustments after the other Arrays PRs got merged.
Right now it looks good to me but we might want to discuss how the generation script is ordered.

WDYT @Amxx ?

[Amxx]

When doing this kind of changes, I think we should aim at minimizing the review work on the solidity side by keeping the function ordering. This greatly reduces the diff size. Once that is merged, we can always discuss another PR that reorder the template (that at this point we know is correct).

Basically, its easy to:

• review template change that don't touch the code to much
• review template reorganisation

But its hard to

• review brand new templates that result in significant solidity movement.

I did some changes to minimize the changes to Array.sol

[ernestognw]

I agree with minimizing the diff. So LGTM as well.
However, I do think the previous ordering is better when reading the generation script. No need to update it now since I don't think the ordering is strictly important, but wanted to point it out.