Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about event access in ERC1967Utils.sol #4861

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Sabnock01
Copy link
Contributor

Fixes #4860

Removes the now non-applicable comment in ERC1967Utils.sol on events being redeclared in the file prior to 0.8.20 which allows qualified event access from external contracts. The comment is no longer applicable since ERC1967Utils.sol was transitioned from an abstract contract to a library and now does not inherit IERC1967.sol.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: 901b624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sabnock01

@ernestognw ernestognw changed the title docs: remove note about event access Remove note about event access in ERC1967Utils.sol Jan 29, 2024
@ernestognw ernestognw enabled auto-merge (squash) January 29, 2024 17:36
@ernestognw ernestognw disabled auto-merge January 29, 2024 17:42
@ernestognw ernestognw merged commit 7439664 into OpenZeppelin:master Jan 29, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note on event access in ERC1967Utils.sol should be removed
2 participants