Group typo fixes #5466
Group typo fixes #5466
Conversation
|
| Name | Type |
|---|---|
| openzeppelin-solidity | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
| @@ -17,7 +17,7 @@ import {SafeCast} from "../../utils/math/SafeCast.sol"; | |||
| * the assets and permissions must be attached to the {TimelockController}. Any asset sent to the {Governor} will be | |||
| * inaccessible from a proposal, unless executed via {Governor-relay}. | |||
| * | |||
| * WARNING: Setting up the TimelockController to have additional proposers or cancellers besides the governor is very | |||
| * WARNING: Setting up the TimelockController to have additional proposers or cancelers besides the governor is very | |||
There was a problem hiding this comment.
canceller and canceler are both correct spellings but 2 l's is more common in British English while the other is American English. We should just be consistent on what we choose.
| @@ -24,7 +24,7 @@ import {Time} from "../../utils/types/Time.sol"; | |||
| * | |||
| * ==== Security Considerations | |||
| * | |||
| * Some operations may be cancelable in the `AccessManager` by the admin or a set of guardians, depending on the | |||
| * Some operations may be cancellable in the `AccessManager` by the admin or a set of guardians, depending on the | |||
There was a problem hiding this comment.
See the comment below. He we are going in the opposite direction. We shouldn't just have these flip-flopping.
There was a problem hiding this comment.
We don't have much consistency throughout the repo. We should choose one and stay with it. I prefer American spelling.
| @@ -21,7 +21,7 @@ library Clones { | |||
| error CloneArgumentsTooLong(); | |||
|
|
|||
| /** | |||
| * @dev Deploys and returns the address of a clone that mimics the behaviour of `implementation`. | |||
| * @dev Deploys and returns the address of a clone that mimics the behavior of `implementation`. | |||
|
|
||
| # Disclaimer |
There was a problem hiding this comment.
I've been against changing archived audits but if consensus is we should change it, that's fine.
The #typo-fixes branches accumulated typo fixes. This branch should be merged before freezing a release candidate.
This is done to avoid multiple small commits on that polute the master branch. All typo fix PR should target this branch.