-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group typo fixes #5466
base: master
Are you sure you want to change the base?
Group typo fixes #5466
Changes from all commits
76ac21c
9cfcf8b
8e91d91
fe75eef
cb3dace
dd33a88
fb942e6
dd797b0
de5f2dc
49c940c
8349c4f
4dd9d06
602dc92
bd09096
70371ff
9f2e129
43f1d30
fdc4001
a196613
12c9e0e
aa94087
64954d8
11f92b7
9a62c3c
282f414
8423d20
839cb42
d70b70a
c75fb05
9340f17
564f5d0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ import {Time} from "../../utils/types/Time.sol"; | |
* | ||
* ==== Security Considerations | ||
* | ||
* Some operations may be cancelable in the `AccessManager` by the admin or a set of guardians, depending on the | ||
* Some operations may be cancellable in the `AccessManager` by the admin or a set of guardians, depending on the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See the comment below. He we are going in the opposite direction. We shouldn't just have these flip-flopping. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't have much consistency throughout the repo. We should choose one and stay with it. I prefer American spelling. |
||
* restricted function being invoked. Since proposals are atomic, the cancellation by a guardian of a single operation | ||
* in a proposal will cause all of the proposal to become unable to execute. Consider proposing cancellable operations | ||
* separately. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ import {SafeCast} from "../../utils/math/SafeCast.sol"; | |
* the assets and permissions must be attached to the {TimelockController}. Any asset sent to the {Governor} will be | ||
* inaccessible from a proposal, unless executed via {Governor-relay}. | ||
* | ||
* WARNING: Setting up the TimelockController to have additional proposers or cancellers besides the governor is very | ||
* WARNING: Setting up the TimelockController to have additional proposers or cancelers besides the governor is very | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
* risky, as it grants them the ability to: 1) execute operations as the timelock, and thus possibly performing | ||
* operations or accessing funds that are expected to only be accessible through a vote, and 2) block governance | ||
* proposals that have been approved by the voters, effectively executing a Denial of Service attack. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ library Clones { | |
error CloneArgumentsTooLong(); | ||
|
||
/** | ||
* @dev Deploys and returns the address of a clone that mimics the behaviour of `implementation`. | ||
* @dev Deploys and returns the address of a clone that mimics the behavior of `implementation`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another british vs american |
||
* | ||
* This function uses the create opcode, which should never revert. | ||
*/ | ||
|
@@ -54,7 +54,7 @@ library Clones { | |
} | ||
|
||
/** | ||
* @dev Deploys and returns the address of a clone that mimics the behaviour of `implementation`. | ||
* @dev Deploys and returns the address of a clone that mimics the behavior of `implementation`. | ||
* | ||
* This function uses the create2 opcode and a `salt` to deterministically deploy | ||
* the clone. Using the same `implementation` and `salt` multiple times will revert, since | ||
|
@@ -158,7 +158,7 @@ library Clones { | |
} | ||
|
||
/** | ||
* @dev Deploys and returns the address of a clone that mimics the behaviour of `implementation` with custom | ||
* @dev Deploys and returns the address of a clone that mimics the behavior of `implementation` with custom | ||
* immutable arguments. These are provided through `args` and cannot be changed after deployment. To | ||
* access the arguments within the implementation, use {fetchCloneArgs}. | ||
* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been against changing archived audits but if consensus is we should change it, that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is consensus. Just grouping everything under one PR.