Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arachnid's and Micah's deployer to the common contracts #5519

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 21, 2025

This is an evolution of the test environment. Shouldn't need a changelog entry.

This is an interresting factory to use with the ERC-4337 entrypoint (in the community repo)

Note: this contract is provided by default in Foundry.

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: f58fdb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx requested review from frangio, arr00 and ernestognw February 21, 2025 18:53
@Amxx Amxx added the tests Test suite and helpers. label Feb 21, 2025
@arr00
Copy link
Contributor

arr00 commented Feb 21, 2025

Should we add another one too so we aren't pushing a specific deployer? I generally use this one by 0age which is deployed on a lot of chains (deployed by micha's deployer).

@Amxx
Copy link
Collaborator Author

Amxx commented Feb 21, 2025

I added arachnid's because it is, afaik, the oldest one, possibly the most widely available, and the one used to deploy the 4337 entry point! Its bytecode is also super small.

I'd be open to adding others, but it don't want that to be a rush to adding more and more. You point one that is itself deployed by Micha's deployer. So should we also include Micha's deployer ?

Edit: after looking at the one you shared, it really looks bulky and opinionated compared to Arachnid's simplicity

@arr00
Copy link
Contributor

arr00 commented Feb 21, 2025

I added arachnid's because it is, afaik, the oldest one, possibly the most widely available, and the one used to deploy the 4337 entry point! Its bytecode is also super small.

I'd be open to adding others, but it don't want that to be a rush to adding more and more. You point one that is itself deployed by Micha's deployer. So should we also include Micha's deployer ?

Edit: after looking at the one you shared, it really looks bulky and opinionated compared to Arachnid's simplicity

Yes, would probably make more sense to simply use micha's deployer which this is derived from. Micha's is over a year older than arachnid's!

arr00
arr00 previously approved these changes Feb 21, 2025
@Amxx Amxx changed the title Add Arachnid's deployer to the common contracts Add Arachnid's and Micha's deployer to the common contracts Feb 21, 2025
@Amxx Amxx changed the title Add Arachnid's and Micha's deployer to the common contracts Add Arachnid's and Micah's deployer to the common contracts Feb 21, 2025
@Amxx
Copy link
Collaborator Author

Amxx commented Feb 21, 2025

Fun fact about "the first factory"

I did not know about Mocah's when I deployed mine.

@Amxx Amxx merged commit 3bdc3a3 into OpenZeppelin:master Feb 21, 2025
15 checks passed
@Amxx Amxx deleted the feature/arachnid-deployer branch February 21, 2025 21:54
@pcaversaccio
Copy link
Contributor

FWIW, I built CreateX:

@Amxx
Copy link
Collaborator Author

Amxx commented Feb 22, 2025

CreateX is really big ! We'll have to consider the cost/benefit of having it by default.

I'm starting to think this script should be an independent hardhat module which can be configured to enable/disable what is needed

@pcaversaccio
Copy link
Contributor

CreateX is really big ! We'll have to consider the cost/benefit of having it by default.

I'm starting to think this script should be an independent hardhat module which can be configured to enable/disable what is needed

Sure - I just wanted to highlight it as it's now the common factory used across dev frameworks. E.g. Hardhat Ignition uses it https://hardhat.org/ignition/docs/guides/create2 as well as Foundry will switch to it as well: foundry-rs/foundry#2638

Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Feb 24, 2025
…elin#5519)

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Feb 24, 2025
…elin#5519)

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changeset tests Test suite and helpers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants