-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arachnid's and Micah's deployer to the common contracts #5519
Conversation
|
Should we add another one too so we aren't pushing a specific deployer? I generally use this one by 0age which is deployed on a lot of chains (deployed by micha's deployer). |
I added arachnid's because it is, afaik, the oldest one, possibly the most widely available, and the one used to deploy the 4337 entry point! Its bytecode is also super small. I'd be open to adding others, but it don't want that to be a rush to adding more and more. You point one that is itself deployed by Micha's deployer. So should we also include Micha's deployer ? Edit: after looking at the one you shared, it really looks bulky and opinionated compared to Arachnid's simplicity |
Yes, would probably make more sense to simply use micha's deployer which this is derived from. Micha's is over a year older than arachnid's! |
Fun fact about "the first factory"
I did not know about Mocah's when I deployed mine. |
FWIW, I built
|
CreateX is really big ! We'll have to consider the cost/benefit of having it by default. I'm starting to think this script should be an independent hardhat module which can be configured to enable/disable what is needed |
Sure - I just wanted to highlight it as it's now the common factory used across dev frameworks. E.g. Hardhat Ignition uses it https://hardhat.org/ignition/docs/guides/create2 as well as Foundry will switch to it as well: foundry-rs/foundry#2638 |
…elin#5519) Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
…elin#5519) Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
This is an evolution of the test environment. Shouldn't need a changelog entry.
This is an interresting factory to use with the ERC-4337 entrypoint (in the community repo)
Note: this contract is provided by default in Foundry.