Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time documentation lacks unit for return values #114

Open
miohtama opened this issue Mar 29, 2020 · 1 comment
Open

time documentation lacks unit for return values #114

miohtama opened this issue Mar 29, 2020 · 1 comment
Labels
documentation Documentation

Comments

@miohtama
Copy link

The time API functions are documented here https://docs.openzeppelin.com/test-helpers/0.5/api#time

However there is no proper definition of what units and types these functions return

  • String vs. int vs. big num
  • Seconds vs. milliseconds
  • Epoch
@frangio frangio changed the title time documentation lacks unit time documentation lacks unit for return values Mar 30, 2020
@abcoathup
Copy link
Contributor

Hi @miohtama! Thanks for the suggestion, it is really appreciated.

The project owner should review your suggestion during the next week.

Please wait until we have discussed this idea before writing any code or submitting a Pull Request, so we can go through the design beforehand. We don’t want you to waste your time!

@abcoathup abcoathup added the documentation Documentation label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

No branches or pull requests

2 participants