Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to visually represent hashes. #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Archethect
Copy link

@Archethect Archethect commented Feb 27, 2025

This PR aims to visually represent the generated hashes.
This should dramatically help comparing hash strings.

Would be good if this could also be included on the Safe side and ideally on HW wallets.

I used react-blockies for this implementation: https://github.com/stephensprinkle-zz/react-blockies#readme

Screenshot 2025-02-27 at 10 52 59

@xaler5
Copy link
Collaborator

xaler5 commented Feb 27, 2025

First contribution attempt :) congrats 🚀

Would be good if this could also be included on the Safe side and ideally on HW wallets.

I agree with this but we already know how difficult is for HW wallets to even implement EIP712 data structures.
This project is meant to be minimal without unnecessary dependencies. This PR adds a dependency which is poorly mantained and we prefer to not take the risks of introducing flaws.

However I agree with your intents of simplifying strings comparison. We already have some thoughts but curious to know what's your opinion in achieving the same without adding extra complexities or relying on third party services to adopt same patterns.

@Archethect
Copy link
Author

Agree.

I see that for the Safe address PixelAvatar is already used. Maybe this one can be extended such that it works for both normal addresses and hashes.

Another idea would be to 'encode' the hash into a human readable form. Similar like what this repo attempts: https://github.com/guyroyse/mnemonic-bytes

@Archethect
Copy link
Author

Agree.

I see that for the Safe address PixelAvatar is already used. Maybe this one can be extended such that it works for both normal addresses and hashes.

Another idea would be to 'encode' the hash into a human readable form. Similar like what this repo attempts: https://github.com/guyroyse/mnemonic-bytes

That being said... I can adapt PixelAvatar to make it work (which wouldn't add extra dependencies) and create a new PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants