Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M-01] Approval Periods Are Implicitly Restricted #57

Merged
merged 9 commits into from
Feb 21, 2025
Merged

Conversation

brozorec
Copy link
Collaborator

@brozorec brozorec commented Feb 12, 2025

close #35

The audit report suggests two ways of addressing this issue:

Consider allowing accounts to specify approvals valid for longer than the maximum TTL value by limiting the TTL extension period to the maximum possible value. ...

and

Alternatively, consider using the permanent storage for storing allowances.

We acknowledge the reasoning behind this suggestions, but decided to keep the current design of implicitly restricted approvals. The main reason is consistency with SAC (Stellar Asset Contract), where temporary storage is used for this data and one can't set a longer TTL than the max allowed. However, we introduce an explicit check/error for the case when live_until_ledger > max_live_until_ledger and explain this limitation in the docs.

@brozorec brozorec added the audit label Feb 12, 2025
@brozorec brozorec requested a review from ozgunozerk February 12, 2025 13:01
@brozorec brozorec self-assigned this Feb 12, 2025
@brozorec brozorec marked this pull request as ready for review February 14, 2025 10:42
@brozorec brozorec mentioned this pull request Feb 19, 2025
2 tasks
@brozorec brozorec merged commit 4a751c7 into main Feb 21, 2025
3 checks passed
@brozorec brozorec deleted the m-01-approvals branch February 21, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[M-01] Approval Periods Are Implicitly Restricted
2 participants