inline docs standardized, and emit removed from set_allowance #87
+38
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
Also, whilst standardizing events and errors, I've noticed something and tinkered with it.
set_allowance()
function is taking a flag as a parameter on whether to emit an event or not.I've followed the every path to
set_allowance()
, and noticed the this flag is only set to true (event is emitted) when it is called by theapprove()
function.I believe
set_allowance
is there to provide the low-level logic for setting the allowance. Andapprove()
function is the high-level one, which should be responsible from:So, I moved the event responsibility to
approve()
function, and the code logic became simpler and shorter as well in return.@brozorec please let me know if this change will have a downside that I didn't think of yet.