Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permissions update from config using requests code path #610

Merged
merged 11 commits into from
Jun 11, 2024

Conversation

fmigneault
Copy link
Member

Tested using magpie.register.magpie_register_permissions_from_config from a script with a set of Permission entries and a remote Magpie instance URL. Updates applied where things broke.

@fmigneault fmigneault requested a review from mishaschwartz June 1, 2024 03:43
@fmigneault fmigneault self-assigned this Jun 1, 2024
@github-actions github-actions bot added the doc Documentation improvements or building problem label Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (154736d) to head (5ee83c5).
Report is 1 commits behind head on master.

Current head 5ee83c5 differs from pull request most recent head 5285b6e

Please upload reports for the commit 5285b6e to get more accurate results.

Files Patch % Lines
magpie/register.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files          73       73           
  Lines       10201    10191   -10     
  Branches     1825     1825           
=======================================
- Hits         8251     8243    -8     
+ Misses       1626     1625    -1     
+ Partials      324      323    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mishaschwartz
mishaschwartz previously approved these changes Jun 5, 2024
@github-actions github-actions bot added tests Test execution or additional use cases ci Something related to code tests, deployment and packaging cli Something related to the CLI helpers labels Jun 10, 2024
@fmigneault
Copy link
Member Author

Added #612 which tests the requests code path while evaluating it.

@fmigneault fmigneault merged commit c349520 into master Jun 11, 2024
19 checks passed
@fmigneault fmigneault deleted the fix-register-perms-request branch June 11, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something related to code tests, deployment and packaging cli Something related to the CLI helpers doc Documentation improvements or building problem tests Test execution or additional use cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Provide a CLI utility to directly load a set of permissions and submit it to a remote instance
2 participants