Skip to content

Commit 0015436

Browse files
committed
runtest: do not change "pavics" to "boreas" as a way to keep on "pavics"
First implementation was bit silly, done in a haste. It causes diff problem when the url is printed back. ``` _ pavics-sdi-fix-subset-user-input.ipynb-for-jenkins/docs/source/notebooks/subset-user-input.ipynb::Cell 12 _ Notebook cell execution failed Cell 12: Cell outputs differ Input: # gather data from pavics' data catalogue catalog = "https://boreas.ouranos.ca/twitcher/ows/proxy/thredds/catalog/datasets/gridded_obs/catalog.xml" # TEST_USE_PROD_DATA cat = TDSCatalog(catalog) data = cat.datasets[0].access_urls["OPENDAP"] data Traceback: mismatch 'text/plain' assert reference_output == test_output failed: "'https://pav...rcan_v2.ncml'" == "'https://bor...rcan_v2.ncml'" Skipping 72 identical trailing characters in diff, use -v to show - 'https://boreas.ouranos ? ^^^^ + 'https://pavics.ouranos ? ^ +++ ```
1 parent b411898 commit 0015436

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

runtest

+3-4
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,11 @@ fi
1616

1717
if [ ! -z "$PAVICS_HOST" ]; then
1818
echo "Will run notebooks against $PAVICS_HOST"
19-
# Any lines marked with TEST_USE_PROD_DATA will replace pavics to boreas to
20-
# use data from prod and avoid having to replicate data to test servers.
21-
sed -i "/TEST_USE_PROD_DATA/s/pavics.ouranos.ca/boreas.ouranos.ca/g" $NOTEBOOKS
2219
# .ncml links will always comes from the production server, not the server
2320
# under test since we do not perform regex replace for .ncml links.
24-
sed -i "/\.ncml/!s/pavics.ouranos.ca/$PAVICS_HOST/g" $NOTEBOOKS
21+
# Any lines marked with TEST_USE_PROD_DATA will replace pavics to boreas to
22+
# use data from prod and avoid having to replicate data to test servers.
23+
sed -i "/\.ncml|TEST_USE_PROD_DATA/!s/pavics.ouranos.ca/$PAVICS_HOST/g" $NOTEBOOKS
2524
git diff # not working for notebooks from other repos
2625
fi
2726

0 commit comments

Comments
 (0)