-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for Thredds v5 #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the following error: ``` _______ pavics-sdi-master/docs/source/notebooks/rendering.ipynb::Cell 2 ________ Notebook cell execution failed Cell 2: Cell outputs differ Input: sorted(wms.contents["tasmax"].styles.keys()) Traceback: mismatch 'text/plain' assert reference_output == test_output failed: "['boxfill/al...fill/sst_36']" == "['colored_co...ter/default']" - ['colored_contours/default', - 'contours', - 'default-scalar/default', - 'raster/default'] + ['boxfill/alg', + 'boxfill/alg2', + 'boxfill/ferret', + 'boxfill/greyscale', + 'boxfill/ncview', + 'boxfill/occam', + 'boxfill/occam_pastel-30', + 'boxfill/rainbow', + 'boxfill/redblue', + 'boxfill/sst_36'] _______ pavics-sdi-master/docs/source/notebooks/rendering.ipynb::Cell 3 ________ Notebook cell execution failed Cell 3: Cell execution caused an exception Input: resp = wms.getmap( layers=["tasmax"], styles=["boxfill/occam"], format="image/png", colorscalerange=f"{mn},{mx}", size=[256, 256], srs="CRS:84", bbox=(150, 30, 250, 80), time="2006-02-15", transparent=True, ) Image(resp.read()) Traceback: --------------------------------------------------------------------------- ServiceException Traceback (most recent call last) Cell In[1], line 1 ----> 1 resp = wms.getmap( 2 layers=["tasmax"], 3 styles=["boxfill/occam"], 4 format="image/png", 5 colorscalerange=f"{mn},{mx}", 6 size=[256, 256], 7 srs="CRS:84", 8 bbox=(150, 30, 250, 80), 9 time="2006-02-15", 10 transparent=True, 11 ) 12 Image(resp.read()) File /opt/conda/envs/birdy/lib/python3.11/site-packages/owslib/map/wms130.py:309, in WebMapService_1_3_0.getmap(self, layers, styles, srs, bbox, format, size, time, elevation, dimensions, transparent, bgcolor, exceptions, method, timeout, **kwargs) 305 data = urlencode(request) 307 self.request = bind_url(base_url) + data --> 309 u = openURL(base_url, data, method, timeout=timeout or self.timeout, auth=self.auth, headers=self.headers) 311 # need to handle casing in the header keys 312 headers = {} File /opt/conda/envs/birdy/lib/python3.11/site-packages/owslib/util.py:210, in openURL(url_base, data, method, cookies, username, password, timeout, headers, verify, cert, auth) 207 req = requests.request(method.upper(), url_base, headers=headers, **rkwargs) 209 if req.status_code in [400, 401]: --> 210 raise ServiceException(req.text) 212 if req.status_code in [404, 500, 502, 503, 504]: # add more if needed 213 req.raise_for_status() ServiceException: <ServiceExceptionReport version="1.3.0" xmlns="http://www.opengis.net/ogc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/ogc http://schemas.opengis.net/wms/1.3.0/exceptions_1_3_0.xsd"> <ServiceException code="StyleNotDefined"> The layer tasmax does not support the style boxfill </ServiceException> </ServiceExceptionReport> ```
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
``` _ pavics-sdi-fix-for-Thredds-v5/docs/source/notebooks/CaSR_basic.ipynb::Cell 4 _ Notebook cell execution failed Cell 4: Cell outputs differ Input: bbox.rotated_pole Traceback: mismatch 'text/plain' assert reference_output == test_output failed: '<xarray.Data...itude: 0.0' == '<xarray.Data...itude: 0.0' Skipping 138 identical leading characters in diff, use -v to show Skipping 67 identical trailing characters in diff, use -v to show utes: - long_name: coordinates of the rotated North Pole earth_radius: 6371220.0 grid_mapping_name: rotated_latitude_longitude grid_north_pole_latitude: 31.758316040039062 grid_north_pole_longitude: 87.59703063964844 + long_name: coordinates of the rotated North Pole long
tlvu
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Dec 5, 2024
## Overview Unidata has dropped support for TDS versions < 5.x. This updates Thredds to version 5.5. Requires matching update: * Ouranosinc/pavics-sdi#341 * Ouranosinc/pavics-sdi#342 * Ouranosinc/PAVICS-landing#101 ## Changes **Non-breaking changes** - Adds... - New component version pavics/thredds-docker:5.5-unidata-2024-11-19-with-tds-plugin-jar-with-dependencies.jar **Breaking changes** - None ## Related Issue / Discussion - Resolves #168 ## Additional Information Links to other issues or sources. <!-- The test suite can be run using a different DACCS config with ``birdhouse_daccs_configs_branch: branch_name`` in the PR description. To globally skip the test suite regardless of the commit message use ``birdhouse_skip_ci: true`` in the PR description. --> birdhouse_daccs_configs_branch: master birdhouse_skip_ci: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Thredds v5 upgrade in bird-house/birdhouse-deploy#413.
For the following error and other output changes:
Output change: