Refactor StructureInspector
#1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit strange having to pass in the `position`, though it does mean the result can be stored in a `const` variable. It also means we don't need to store extra data in the class instance to handle this. Long term we should probably make both tables fields of the class, rather than rebuild them every frame. Though doing so would mean moving the `#include` for `StringTable.h` to the `StructureInspector` header file. That has transitive include implications, which I'd like to avoid for the time being.
There's really no need to update the `title` every frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General refactoring of
StructureInspector, which will hopefully make it easier to eventually dynamically resize this view.Related: