Skip to content

Set writeAttribute return type #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

radarhere
Copy link
Contributor

@radarhere radarhere commented Apr 25, 2025

Description

Fixes #2204. Uses the writeAttribute() return type documented at https://www.php.net/manual/en/xmlwriter.writeattribute.php

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

My CI is mostly green - it unrelatedly complains about loripsum.net being down - https://github.com/radarhere/PHPWord/actions/runs/14656574578
This specific method isn't mentioned in the docs.
Since #2239 didn't seem to be significant enough for the changelog, I don't expect this is either.

radarhere referenced this pull request in tbar0970/jethro-pmm Apr 25, 2025
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radarhere Hi,

Could you rebase your PR and update the changelog file (docs/changes/1.x/1.5.0.md), please ?

@Progi1984 Progi1984 added this to the 1.5.0 milestone Jun 5, 2025
@coveralls
Copy link

coveralls commented Jun 5, 2025

Coverage Status

coverage: 96.76% (+0.008%) from 96.752%
when pulling e71a3c2 on radarhere:writeAttribute
into 6d75328 on PHPOffice:master.

@Progi1984 Progi1984 merged commit a3de6ef into PHPOffice:master Jun 5, 2025
30 checks passed
@radarhere radarhere deleted the writeAttribute branch June 5, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

XMLWriter incompatibility in the writeAttribute method in PHP 8.1.2
3 participants