Skip to content

Code fixes to make a CI green #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2025
Merged

Code fixes to make a CI green #2784

merged 3 commits into from
May 30, 2025
+23 −4

Conversation

michalschroeder
Copy link
Contributor

@michalschroeder michalschroeder commented May 30, 2025 •
edited by Progi1984
Loading

Description

Making CI green to unblock Security fix for phpoffice/math PR

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@michalschroeder michalschroeder mentioned this pull request May 30, 2025
Closed
@coveralls
Copy link

coveralls commented May 30, 2025 •
edited
Loading

Coverage Status

coverage: 96.752% (-0.02%) from 96.767%
when pulling f949f02 on michalschroeder:ci-fixes
into 6ca8c9f on PHPOffice:master.

@Progi1984
Copy link
Member

@michalschroeder Hi, thanks.

Could you update the changelog, please ?

@michalschroeder
Copy link
Contributor Author

@Progi1984 sure, changelog updated f949f02

@Progi1984 Progi1984 merged commit 1f28d36 into PHPOffice:master May 30, 2025
30 checks passed
@Progi1984
Copy link
Member

@michalschroeder Thank you. It's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalschroeder @coveralls @Progi1984