DIS-51: refactor: Only load patron dob

Load patron dob when needed rather than storing in the database

Author: AlexanderBlanchardAC

code/web/Drivers/Koha.php

@@ -1229,14 +1229,15 @@ private function loadPatronInfoFromDB($patronId, $password, $suppliedUsernameOrB
 			$user->ils_password = $password;
 			$user->email = $userFromDb['email'];
 			$user->patronType = $userFromDb['categorycode'];
-			$user->dateOfBirth = $userFromDb['dateofbirth'];
 
 			$user->_address1 = trim($userFromDb['streetnumber'] . ' ' . $userFromDb['address']);
 			$user->_address2 = $userFromDb['address2'];
 			$user->_city = $userFromDb['city'];
 			$user->_state = $userFromDb['state'];
 			$user->_zip = $userFromDb['zipcode'];
 			$user->phone = $userFromDb['phone'];
+			$user->_dateOfBirth = $userFromDb['dateofbirth'];
+
 
 			$user->_web_note = $userFromDb['opacnote'];
 
@@ -1341,7 +1342,7 @@ private function loadPatronInfoFromDB($patronId, $password, $suppliedUsernameOrB
 
 	function loadContactInformation(User $user) {
 		$this->initDatabaseConnection();
-		$sql = "SELECT borrowernumber, cardnumber, surname, firstname, streetnumber, streettype, address, address2, city, state, zipcode, country, email, phone, mobile, categorycode, dateexpiry, password, userid, branchcode, opacnote, privacy from borrowers where borrowernumber = '" . mysqli_escape_string($this->dbConnection, $user->unique_ils_id) . "';";
+		$sql = "SELECT borrowernumber, cardnumber, surname, firstname, streetnumber, streettype, address, address2, city, state, zipcode, country, email, phone, mobile, categorycode, dateexpiry, password, userid, branchcode, opacnote, privacy, dateofbirth from borrowers where borrowernumber = '" . mysqli_escape_string($this->dbConnection, $user->unique_ils_id) . "';";
 
 		$lookupUserResult = mysqli_query($this->dbConnection, $sql, MYSQLI_USE_RESULT);
 		if ($lookupUserResult) {
@@ -1358,6 +1359,7 @@ function loadContactInformation(User $user) {
 			$user->_state = $userFromDb['state'];
 			$user->_zip = $userFromDb['zipcode'];
 			$user->phone = $userFromDb['phone'];
+			$user->_dateOfBirth = $userFromDb['dateofbirth'];
 		}
 	}
 

code/web/sys/Account/User.php

@@ -52,7 +52,6 @@ class User extends DataObject {
 	public $userCookiePreferenceLocalAnalytics;
 	public $holdInfoLastLoaded;
 	public $checkoutInfoLastLoaded;
-	public $dateOfBirth;
 
 	public $onboardAppNotifications;
 	public $shouldAskBrightness;
@@ -129,6 +128,8 @@ class User extends DataObject {
 	public $_noticePreferenceLabel;
 	private $_numMaterialsRequests = 0;
 	private $_readingHistorySize = 0;
+	public $_dateOfBirth;
+
 
 	// CarlX Option
 	public $_emailReceiptFlag;
@@ -3116,15 +3117,13 @@ public function getPTypeObj(): ?PType {
 	 * @return int|null The user's age or null if date of birth is not set.
 	*/
 	public function getAge(): ?int {
-		if (empty($this->dateOfBirth)) {
-			return null;
-		}
-
-		$dob = new DateTime($this->dateOfBirth);
+		
+		$this->loadContactInformation();
+		
+		$dob = new DateTime($this->_dateOfBirth);
 		$today = new DateTime();
 
 		$age = $dob->diff($today)->y;
-
 		return $age;
 	}