Filter Holds #160
Merged
Filter Holds #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to filter holds by excluding those of selected linked users and by displaying only selected holds in the UI.
Update exportHolds so that the new filters are taken into account when holds are exported.
|
Seems to be working nicely and as expected, would add return types to remove the need for them to be manually added upon merge with main Edit: two minor issues found in further testing:
|
AlexanderBlanchardAC
force-pushed
the
DIS-219-Filter-Holds
branch
from
70386ad to
e09f658
Compare
Prevent disply selected filter from filtering out linked users if they are highlighted in the ui
When records are selected and display selected is applied, records were being returned if they had the same record id as a selected record e.g. they had a different user, but were not selected themseleves, this patch adds a check for the userid to prevent this
AlexanderBlanchardAC
changed the base branch from
DIS-219-Filter-Holds
to
DIS-219-Filter-Hold-Requests
|
Looks to be working as expected with both issues noted during testing now resolved |
AlexanderBlanchardAC
merged commit 1674912
into
PTFS-Europe:DIS-219-Filter-Hold-Requests
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://aspen-discovery.atlassian.net/jira/software/c/projects/DIS/boards/2?search=219&selectedIssue=DIS-219
This Pull Request adds filtering options to the holds section in a user account.