Slim down cookie consent template #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch refactors the cookie-consent.tpl file so that there are less lines of code. The logged in check now only applies to the button relevant to it instead of duplicating the banner code in two seperate if clauses. To test: 1. Enable cookie consent 2. Check that banner still disappears on selecting cookie preferences 3. Check that the bar does not reappear on refresh 4. Log out 5. Bar should appear again 6. Check steps 2-3 again
|
Tested functionality: working nicely and as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the cookie-consent.tpl to reduce the lines of code. The $loggedIn clause now only applies to the manage button of the banner.
Test plan in main commit.