25.02.00 newsletter consent koha integration #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow existing sites to be updated to include the database change. Test plan: - In Aspen Administration > System Administration > DB Maintenance, scroll down to find "Save Library ILS Consent Feature Toggle Value" - Run the update and notice that it is succesful
This changes how Aspen determines whether the ILS it is set to use support an ILS Consent integration, by implementing an 'hasIlsConsentSupport' method, instead of relying on 'method_exists' checks. The functionality, which remains unchanged, is as follows: As of now, Koha is the only ILS for which this exists, and therefore, for any other ILS, Administrators will not see the 'Enable ILS-issued consents' setting option in Library Systems > Data Protection Regulations.
Chloe070196
force-pushed
the
25.02.00_newsletter_consent_koha_integration
branch
from
c4d029b to
6e9ec4b
Compare
So that no unecessary API calls are executed, this introduces a check for the Koha plugin which allows for patron consents found in Koha to be viewed and edited by patrons in Aspen. If the plugin is not installed, or not enabled, then: - administrators will be unable to see and set 'Enable ILS-issued consents' - if the Koha plugin was installed and active, and 'Enabled ILS-issued consents' was enabled in Aspen, but the Koha plugin is later uninstalled or disabled, then an error message will show to warn patrons that the feature to view and edit their consent is unavailable due to a technical issue. Test plan: - while the Newsletter Consent plugin is installed and enabled in Koha, in Aspen Administration > Library Systems > Data Protection Regulations, enable 'Enable ILS-issued consents'. - disable or unistall the Newsletter Consent plugin in Koha - masquerade or log in as a patron - navigate to 'Your Privacy Settings' and notice the warning message that shows - re-install / enable the Newsletter Consent plugin in Koha - reload the 'Privacy Settings' page in Aspen, and notice that instead of seeing the warning, you now can view and edit your consents once more
Note:
Assumes that Koha has been set up as the ILS, and
that the koha-plugin-newsletter-consent plugin
is enabled.
Test plan:
- login or masquerade as a patron
- view the Privacy Settings page
- notice that information irrelevant to patron has
been removed from the tooltip
- notice that the formulation is improved ('to
receiving our Newsletter' instead of
'to our Newsletter')
- disable the Koha newsletter plugin
(or uninstall it)
- notice that the message showing on Privacy
Settings now shows on a blue background (instead
of red), and has been reworded for clarity.
Chloe070196
force-pushed
the
25.02.00_newsletter_consent_koha_integration
branch
from
741d4a2 to
84cd79a
Compare
Chloe070196
merged commit 0af7f9c
into
PTFS-Europe:25.02.00_newsletter_consent_koha_integration
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR here: #156
Current Aspen PR: Aspen-Discovery#2198
Implement the following requested changes:
hasIlsConsentSupportmethod instead of usingmethod_existsAdditionally, it updates the messages displayed to the patrons so they are clearer, and adds missing return types to methods created as part of DIS-98.