DIS-219: Reverse Filter #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse the logic of the filter so that is filters to include records rather than exclude them. Add the current user to the filters so that the user can view just their own records.
Fix issue found in testing, move linked user filter to display whether or not there are holds found and ensure display selected effectd only the unavailable holds section
AlexanderBlanchardAC
force-pushed
the
DIS-219-Filter-Holds
branch
from
42a5f73 to
8a072a6
Compare
|
Working as intended - can confirm that available holds now still display when the filter by linked user feature is used |
AlexanderBlanchardAC
merged commit ce67291
into
PTFS-Europe:DIS-219-Filter-Hold-Requests
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse the filtering of linked users so that linked users are filtered in rather than out of being displayed.
Ensure that the filter only appears once, it will appear above the first section that had content - available holds or unavailable holds.