DIS-477 FIX search type reset #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May affect Advanced Search functionality - further testing required Need to see if any search Index type and search type is potentially broken by this. Also ideally need to test saved searches, and anything else that relies on So far, no side-effects have been found. |
The following applies to EBSCO EDS and Summon searches. Searches of searchType 'ebsco_eds' and 'summon' see their 'searchIndex' value assign to the 'type' URL parameter. If the value of $this->searchTerms[0]['index'] is assigned to 'type=', it causes said value to be completely ignored when a search is carried out. This results in applying a facet causing the searchIndex value to be systematically ignored, as Aspen apparently expects this value to be assigned to a 'searchIndex' URL parameter, and not 'type'. This commit adds 'ebsco_eds' and 'summon' to the searchTypes for which 'searchIndex' is assigned to the 'searchIndex' URL parameter.
Chloe070196
force-pushed
the
DIS-477_fix_search_type_reset
branch
from
b12a92c to
a1404cc
Compare
|
This allows the selection in the dropdown box to remain selected when a filter from a facet is added. Working as expected. |
Chloe070196
merged commit d2bf48f
into
PTFS-Europe:DIS-477_fix_search_type_reset
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://aspen-discovery.atlassian.net/browse/DIS-477