Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-477 FIX search type reset #194

Merged
merged 2 commits into from
Mar 12, 2025
Merged

DIS-477 FIX search type reset #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9706dc9
DIS-477: fix: assign index value to searchIndex
Chloe070196 Mar 12, 2025
a1404cc
DIS-477: docs: update release notes
Chloe070196 Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions code/web/release_notes/25.04.00.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
//alexander

//chloe
- Prevent search filters (facets) from resetting the search index to its default (commonly, 'Text') for EBSCO EDS and Summon searches. (DIS-477) (*CZ*)

//nick

Expand Down
6 changes: 5 additions & 1 deletion code/web/sys/SearchObject/BaseSearcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,11 @@ protected function getSearchParams() {
$params[] = "lookfor=" . urlencode($this->searchTerms[0]['lookfor']);
}
if (isset($this->searchTerms[0]['index'])) {
if ($this->searchType == 'basic') {
if (
$this->searchType == 'basic' ||
$this->searchType == 'ebsco_eds' ||
$this->searchType = 'summon'
) {
$params[] = "searchIndex=" . urlencode($this->searchTerms[0]['index']);
} else {
$params[] = "type=" . urlencode($this->searchTerms[0]['index']);
Expand Down