Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] h7: eth: add checks for PHYID in stm32_phyinit #328

Merged

Conversation

dakejahl
Copy link
Contributor

@davids5
Copy link
Member

davids5 commented Feb 15, 2025

@dakejahl Please do a PX4 PR that will CI test this branch. Once that passes I will merge this branch and you can rebase the PX4 Branch to point to head in NuttX. Please see other backports and use the same naming constructs. in your PRs.

@dakejahl
Copy link
Contributor Author

Please see other backports and use the same naming constructs. in your PRs.

Are you referring to the commit message? This is the same commit message as the upstream commit. I think you're saying I should have named it arch/stm32h7 instead of h7?

@dakejahl
Copy link
Contributor Author

PX4 PR here
PX4/PX4-Autopilot#24348

@davids5
Copy link
Member

davids5 commented Feb 17, 2025

@dakejahl Please resolve the nuttx related build issues.

@dakejahl
Copy link
Contributor Author

@dakejahl Please resolve the nuttx related build issues.

The only nuttx related build issue is flash overflow on fmu-v6x, unrelated to this PR

@dakejahl
Copy link
Contributor Author

@davids5

@davids5
Copy link
Member

davids5 commented Feb 21, 2025

@davids5

@dakejahl Please spend the time to fix the embedded build. coordinate with @dagar

@dakejahl dakejahl requested a review from dagar February 21, 2025 09:56
@dakejahl
Copy link
Contributor Author

@davids5 there are no issues with the embedded build. Please take a look at the checks
https://github.com/PX4/PX4-Autopilot/pull/24348/checks

@davids5 davids5 merged commit 205b310 into PX4:px4_firmware_nuttx-10.3.0+ Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants