Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

固件升级流程中版本判断逻辑的缺陷引发固件回退问题 #5

Open
yjun123 opened this issue Dec 2, 2024 · 0 comments

Comments

@yjun123
Copy link

yjun123 commented Dec 2, 2024

一、问题描述
在 pxview 启动过程中,其会对当前设备的版本与 pxview 所携带的固件版本进行比对。然而,当二者版本不匹配时,系统会直接将设备固件更新为 pxview 所带的固件,这一操作致使固件出现回退到老版本的情况,相关代码段位于:

https://github.com/PXLogic/PXView/blob/8c9ef4925fc8da8cf2ec862650c8e346445dffd0/libsigrok/hardware/pxlogic/pxlogic.c#L739C13-L739C61

二、预期行为
在进行固件升级时,若 pxview 所携带的固件版本号与当前设备版本号不同,且 设备的固件版本号更高, 应该保持当前设备固件不变, 而不是回退到老版本。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant