Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Desktop gallery page #26

Closed
wants to merge 4 commits into from

Conversation

radhika-khatter
Copy link

Description

This PR adds the Desktop Gallery Page to the project, designed to display high-quality wallpapers optimized for desktop and laptop screens. It includes:
Highlighted Sidebar: The "Desktop" category is highlighted by default for easy navigation.
Desktop Wallpapers: Wallpapers tailored for desktop and laptop resolutions.
Navbar Highlight: The active "Gallery" tab is underlined for better user navigation.
User-Friendly Layout: Simple and intuitive design for easy browsing.


Type of Change

  • 🆕 New Feature
  • 🐛 Bug Fix
  • 🖼 Wallpaper Added
  • 🎨 UI/Design Update
  • 🔄 Refactor/Code Improvement
  • 📂 Other (Specify here):

Issue Linked:
Fixes #23


Checklist

  • 📖 I have read and followed the Contributing Guidelines.
  • ✅ My code adheres to the project's style guidelines.
  • 🧪 I have tested my changes locally and ensured no existing functionality is broken.
  • ✍️ I have added or updated necessary documentation where applicable (e.g., README.md, DESIGN.md, WALLPAPER.md).

Additional Notes

This page serves as the default view when users click on the "Gallery" section in the navigation bar. It is specifically tailored to display wallpapers designed for desktop and laptop screens, categorized by format.

Video Submission

Here is a video demonstrating the changes made in this pull request:
[Watch the video here] https://github.com/radhika-khatter/WallGodds/blob/main/Frontend/PR1.mp4

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @radhika-khatter for your PR! A maintainer will review it shortly. We appreciate your contribution!

@Parnab03
Copy link
Owner

The alignments in your changes do not match the exact specifications of the Figma file. The Figma file provides the precise alignments that need to be followed.

  1. On the sidebar, the border should have a border-radius of 10px.
  2. On the navbar, the bottom border does not fully cover the text—it is at 85% of the text width. Additionally, there should be some padding at the bottom of the text.

Due to these issues, your PR cannot be accepted. You need to make the changes as specified in the Figma design.

For future PRs, please share your work in the frontend-discussion channel on Discord before raising the PR. Include:

  • The issue number.
  • The issue title.
  • The changes you made.
  • The context of your work.

This approach will help both of us better understand and review your contributions before submitting a PR.

Copy link
Owner

@Parnab03 Parnab03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things need to be change.

@Parnab03 Parnab03 closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 DESKTOP GALLERY PAGE
2 participants