Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error404 module and modify App.jsx #27

Closed
wants to merge 1 commit into from

Conversation

Swapnadip2005
Copy link
Contributor

@Swapnadip2005 Swapnadip2005 commented Jan 27, 2025

Description

This pull request adds a new Error404 module and modifies the App.jsx and index.html files.

  • The Error404 module includes its JSX file, CSS module, and assets to improve error handling and user experience.
  • Updates to App.jsx ensure integration of the Error404 module.
  • Modifications to index.html enhance the application's structure and meta content.

Motivation:
These changes aim to improve the application's error handling by providing a dedicated Error404 page, ensuring users are guided effectively when encountering broken links or missing pages.


Type of Change

  • 🆕 New Feature
  • 🐛 Bug Fix
  • 🖼 Wallpaper Added
  • 🎨 UI/Design Update
  • 🔄 Refactor/Code Improvement
  • 📂 Other (Specify here):

Issue Linked:
Fixes #20


Checklist

  • 📖 I have read and followed the Contributing Guidelines.
  • ✅ My code adheres to the project's style guidelines.
  • 🧪 I have tested my changes locally and ensured no existing functionality is broken.

Video

WallGodds.-.Google.Chrome.2025-01-27.21-50-46.mp4

Additional Notes

The Error404 module is a new addition and may require future adjustments as the application evolves.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @Swapnadip2005 for your PR! A maintainer will review it shortly. We appreciate your contribution!

@Parnab03
Copy link
Owner

Thank you for your contribution, @Swapnadip2005.

However, your PR does not align with our guidelines, specifically #25. Additionally, it doesn't follow the instructions we discussed on Discord.

Guidelines: #25
Discord Message: https://discord.com/channels/1319563461423792179/1332244683241558036/1333439753307160608

For that we are not accepting your PR.

@Swapnadip2005
Copy link
Contributor Author

Swapnadip2005 commented Jan 27, 2025

I have checked the guidelines and attached the Video submission as mentioned. You can check once please @Parnab03. Thank You !!

@Parnab03
Copy link
Owner

I have checked the guidelines and attached the Video submission as mentioned. You can check once please @Parnab03. Thank You !!

However, it doesn’t meet guidelines #25 and misses the following:

  • "Page Not Found" tag at the bottom right.
  • Window size is larger than specified in the Figma file.

You are advised to discuss the issue on Discord before raising incomplete issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 404: PAGE NOT FOUND PAGE
2 participants