Skip to content

Fix some Smart Linking quirks #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acicovic opened this issue Nov 11, 2024 · 0 comments
Open

Fix some Smart Linking quirks #2930

acicovic opened this issue Nov 11, 2024 · 0 comments
Labels
Bug Ticket that is a bug report Feature: PCH Ticket/PR related to the Content Helper Maintenance Ticket/PR related to codebase maintenance tasks wp-parsely Required label for all issues

Comments

@acicovic
Copy link
Collaborator

Describe the bug

Smart Linking has some quirks. Specifically:

Quirk 1

  1. If we ask for Smart Link suggestions and press Reject for all of them, we finish with an empty left-hand list the dialog:
image
  1. In addition, if under that state we press Accept, the suggested Smart Link gets added to the content.

Quirk 2

Let's say that we generate 2 links for a Block. We accept the first link and we reject the second. Finally, we press Remove for the link we've just accepted. We'll get "Successfully added 1 smart links." notifications.

Quirk 3

Not really a quirk, but something which can look like one. When we've only got 1 suggestion, the Previous and Next buttons are still being displayed, and they aren't visibly disabled (although they don't work, styling remains the same).

image

If there is no way to have a visibly disabled state, I think we could hide them when only 1 item is in the list.

@acicovic acicovic added Bug Ticket that is a bug report Maintenance Ticket/PR related to codebase maintenance tasks labels Nov 11, 2024
@acicovic acicovic added this to the Future Milestone milestone Nov 11, 2024
@acicovic acicovic added the Feature: PCH Ticket/PR related to the Content Helper label Nov 11, 2024
@acicovic acicovic added the wp-parsely Required label for all issues label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Ticket that is a bug report Feature: PCH Ticket/PR related to the Content Helper Maintenance Ticket/PR related to codebase maintenance tasks wp-parsely Required label for all issues
Projects
None yet
Development

No branches or pull requests

1 participant