-
Notifications
You must be signed in to change notification settings - Fork 33
Traffic Boost: Add UI components for the Traffic Boost functionality #3064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # build/content-helper/dashboard-page.asset.php # build/content-helper/dashboard-page.js
src/content-helper/dashboard-page/components/posts-table/style.scss
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/preview.scss
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/preview.scss
Outdated
Show resolved
Hide resolved
...tent-helper/dashboard-page/pages/traffic-boost/sidebar/components/links-list/links-list.scss
Outdated
Show resolved
Hide resolved
...tent-helper/dashboard-page/pages/traffic-boost/sidebar/components/tabs/inbound-links-tab.tsx
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/sidebar/sidebar.scss
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/sidebar/sidebar.scss
Outdated
Show resolved
Hide resolved
...ontent-helper/dashboard-page/pages/traffic-boost/sidebar/components/tabs/suggestions-tab.tsx
Outdated
Show resolved
Hide resolved
...ontent-helper/dashboard-page/pages/traffic-boost/sidebar/components/tabs/suggestions-tab.tsx
Outdated
Show resolved
Hide resolved
@@ -7,6 +7,8 @@ | |||
@import "../components/tone-selector/style"; | |||
@import "../components/persona-selector/style"; | |||
@import "../components/input-range/style"; | |||
@import "../components/thumbnail/style"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily a thing to do in this PR, but if we think that common.scss
is becoming to big, loading to much CSS in places where it isn't needed, we could see how to improve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think ideally we should try to have the common components (and all its styles) as an independent module, so it would be loaded before all the other PCH code. This would probably help shrinking the size of the editor-sidebar.js
module to be under 256kb and stop webpack from complaining.
But definitely it's work for another PR.
src/content-helper/dashboard-page/pages/traffic-boost/preview/components/preview-iframe.tsx
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/components/preview-iframe.tsx
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/components/preview-iframe.tsx
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/components/preview-iframe.tsx
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/hooks/use-iframe-highlight.ts
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/hooks/use-iframe-highlight.ts
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/preview.tsx
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/preview.tsx
Outdated
Show resolved
Hide resolved
src/content-helper/dashboard-page/pages/traffic-boost/preview/preview.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent work, and a major contribution to our project. Thank you for working on this!
Description
This PR implements most of the UI functionality for the Traffic Boost functionality.
There are a couple mockup functions that will be removed once the missing backend is implemented.
Motivation and context
How has this been tested?
Tested on my local environment and on the latest Chrome.
Screenshots (if appropriate)
@coderabbitai ignore
Summary by CodeRabbit
Release Notes
New Features
Improvements
Components Added
Technical Enhancements