Merge pull request #6954 from Particular/sc-eventing-custom-queue

Warning about custom error queue when doing ServiceControl integration
Particular · Jan 16, 2025 · a24d18b · a24d18b
2 parents 77dfdcb + c2fe525
commit a24d18b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/.../servicecontrol/events-subscription/ServiceControlContracts_3/EndpointsMonitor/Program.cs b/.../servicecontrol/events-subscription/ServiceControlContracts_3/EndpointsMonitor/Program.cs
@@ -11,7 +11,10 @@ static async Task Main()
         endpointConfiguration.UseSerialization<NewtonsoftJsonSerializer>();
         endpointConfiguration.EnableInstallers();
         endpointConfiguration.UsePersistence<InMemoryPersistence>();
-        endpointConfiguration.SendFailedMessagesTo("error");
+
+#region ServiceControlEventsMonitorCustomErrorQueue
+        endpointConfiguration.SendFailedMessagesTo("error-monitoring");
+#endregion
 
         var transport = endpointConfiguration.UseTransport<LearningTransport>();
 

diff --git a/.../servicecontrol/events-subscription/ServiceControlContracts_4/EndpointsMonitor/Program.cs b/.../servicecontrol/events-subscription/ServiceControlContracts_4/EndpointsMonitor/Program.cs
@@ -11,7 +11,10 @@ static async Task Main()
         endpointConfiguration.UseSerialization<NewtonsoftJsonSerializer>();
         endpointConfiguration.EnableInstallers();
         endpointConfiguration.UsePersistence<NonDurablePersistence>();
-        endpointConfiguration.SendFailedMessagesTo("error");
+
+#region ServiceControlEventsMonitorCustomErrorQueue
+        endpointConfiguration.SendFailedMessagesTo("error-monitoring");
+#endregion
 
         var transport = endpointConfiguration.UseTransport<LearningTransport>();
 

diff --git a/.../servicecontrol/events-subscription/ServiceControlContracts_5/EndpointsMonitor/Program.cs b/.../servicecontrol/events-subscription/ServiceControlContracts_5/EndpointsMonitor/Program.cs
@@ -11,7 +11,10 @@ static async Task Main()
         endpointConfiguration.UseSerialization<NewtonsoftJsonSerializer>();
         endpointConfiguration.EnableInstallers();
         endpointConfiguration.UsePersistence<NonDurablePersistence>();
-        endpointConfiguration.SendFailedMessagesTo("error");
+
+#region ServiceControlEventsMonitorCustomErrorQueue
+        endpointConfiguration.SendFailedMessagesTo("error-monitoring");
+#endregion
 
         var transport = endpointConfiguration.UseTransport<LearningTransport>();
 

diff --git a/samples/servicecontrol/events-subscription/sample.md b/samples/servicecontrol/events-subscription/sample.md
@@ -85,6 +85,10 @@ In order to get notifications when the exposed ServiceControl events occur, crea
 
 snippet: ServiceControlEventsHandlers
 
+> [!IMPORTANT]
+> In order to prevent infinate message loops (processing of an integration event fails, the faulting message is moved to the ServiceControl error queue and triggers yet another integration event) the monitoring endpoint must use a dedicated error queue, separte from the ServiceControl one. 
+
+snippet: ServiceControlEventsMonitorCustomErrorQueue
 
 ## Notes on other transports