-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to subset atlases #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. One question - is using atlases
more intuitive for you than atlas_names
? It's ultimately being used as an atlas ID
Thanks! I think |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
=========================================
+ Coverage 0 82.51% +82.51%
=========================================
Files 0 48 +48
Lines 0 5846 +5846
Branches 0 786 +786
=========================================
+ Hits 0 4824 +4824
- Misses 0 826 +826
- Partials 0 196 +196 ☔ View full report in Codecov by Sentry. |
Closes #995.
Changes proposed in this pull request
--skip-parcellation
and--atlases
, to control which atlases are used for parcellation.--skip-parcellation
will set theatlases
parameter to an empty list ([]
), so that no atlases are used for parcellation, and the parcellation workflow doesn't happen.--atlases
will set theatlases
parameter. Users can provide a space-separated list of which atlases they actually want to use. The default is to use all of the atlases in XCP-D.Documentation that should be reviewed