-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-7 Remove redundant ci-default.yml #3774
Conversation
Server docker: perconalab/pmm-server-fb:PR-3774-8757353 |
API tests have failed: https://pmm.cd.percona.com/job/pmm3-api-tests/1501/ |
@@ -42,8 +44,17 @@ def read_config_override(self): | |||
return yaml.load(f, Loader=yaml.FullLoader) | |||
|
|||
def read_config(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read_submodules?
Server docker: perconalab/pmm-server-fb:PR-3774-e6af5d5 |
API tests have failed: https://pmm.cd.percona.com/job/pmm3-api-tests/1568/ |
https://jira.percona.com/browse/PMM-7
Problem
We are managing two similar data structures: one in
.gitmodules
and one inci-default.yml
. The second one is currently being used byci.py
, which combines it with theconfig overrides
located inci.yml
. It turns out, we can still achieve the goal withoutci-default.yml
, since the Python script can read as well from the.gitmodules
config file.Solution
Get rid of
ci-default.yml
, which contains the same data as.gitmodules
.This PR does that and it also refactors the code of
ci.py
.