Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-13556 Add watchtower submodule. #3777

Merged
merged 5 commits into from
Dec 4, 2024
Merged

PMM-13556 Add watchtower submodule. #3777

merged 5 commits into from
Dec 4, 2024

Conversation

talhabinrizwan
Copy link
Contributor

ademidoff
ademidoff reviewed Nov 20, 2024
View reviewed changes
.gitmodules
@@ -51,6 +51,10 @@
path = sources/pmm-dump
url = https://github.com/percona/pmm-dump
branch = v3
[submodule "watchtower"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add it to ci-default.yml as well, at least until we merge this PR.

BupycHuk
BupycHuk approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't merge it until Beta release

@JNKPercona
Copy link
Collaborator

Server docker: perconalab/pmm-server-fb:PR-3777-b3e94ec
Client docker: perconalab/pmm-client-fb:PR-3777-b3e94ec
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-3777-b3e94ec.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-3777-b3e94ec&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-3777-b3e94ec.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have failed: https://pmm.cd.percona.com/job/pmm3-api-tests/1516/

@talhabinrizwan talhabinrizwan merged commit 1612192 into v3 Dec 4, 2024
1 check was pending
@talhabinrizwan talhabinrizwan deleted the PMM-13556-add-watchtower-as-submodule branch December 4, 2024 05:29
@JNKPercona
Copy link
Collaborator

Server docker: perconalab/pmm-server-fb:PR-3777-911013f
Client docker: perconalab/pmm-client-fb:PR-3777-911013f
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-3777-911013f.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-3777-911013f&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-3777-911013f.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have failed: https://pmm.cd.percona.com/job/pmm3-api-tests/1574/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ademidoff ademidoff ademidoff left review comments

@BupycHuk BupycHuk BupycHuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talhabinrizwan @JNKPercona @ademidoff @BupycHuk