Testing the service definitions & improving env loading (#8)

* Testing the services definition
* Improving the env handling for the generic handler

Author: floriankraemer

config/services.yaml

@@ -22,6 +22,7 @@ services:
   Phauthentic\Symfony\ProblemDetails\ExceptionConversion\GenericExceptionConverter:
     arguments:
       $problemDetailsFactory: '@Phauthentic\Symfony\ProblemDetails\ProblemDetailsFactoryInterface'
+      $environment: '%kernel.environment%'
     tags: ['phauthentic.problem_details.exception_converter']
 
   Phauthentic\Symfony\ProblemDetails\ThrowableToProblemDetailsKernelListener:

src/ExceptionConversion/GenericExceptionConverter.php

@@ -26,7 +26,7 @@ class GenericExceptionConverter implements ExceptionConverterInterface
      */
     public function __construct(
         protected ProblemDetailsFactoryInterface $problemDetailsFactory,
-        protected string $environment = 'prod',
+        protected string $environment,
         protected array $mappers = []
     ) {
     }

tests/Unit/ExceptionConversion/GenericExceptionConverterTest.php

@@ -25,7 +25,8 @@ public function setUp(): void
         parent::setUp();
 
         $this->converter = new GenericExceptionConverter(
-            problemDetailsFactory: new ProblemDetailsFactory()
+            problemDetailsFactory: new ProblemDetailsFactory(),
+            environment: 'prod'
         );
     }
 

tests/Unit/ServiceLoadingTest.php

@@ -25,6 +25,7 @@ public function testCreateValidResponse(): void
         $container = new ContainerBuilder();
         $loader = new YamlFileLoader($container, new FileLocator(__DIR__ . '/../../config'));
         $loader->load('services.yaml');
+        $container->setParameter('kernel.environment', 'prod');
         $container->compile();
 
         // Assert