Skip to content

Commit a541c5c

Browse files
authored
Torus ransac model (#5816)
* First torus commit * Torus ransac * integrating projectPoints * Implementing more functions * Slight progress * Adding optimizeModelCoefficients * Adding an example to test during implementation * Fix a bit of the mess between Vector3 and Vector4 float / double types * Progress * Optimizer now works! * Important milestone: * optimizeModelCoefficients is ready * Moved the implementation towards a "normal based" approach * computeModelCoefficients is also ready * Removes normals * Reverting unnecessary changes.. * Several changes: * Removing torus example to test * Unsupressing errors, fixing them but some things are still not adressed * Restores unrequired file modifications * Restoring unnecessary modifications * Updating doxygen * Adds clangformat to new files * Implements a direct approach to torus SAC, with normals * Cleans up a bit, fixes some implementation issues * Fixes equation, tests are now passing * Fixed some bugs, added tests, cleanup * Fixes clang-format * Implements isModelValid * implements doSamplesVerifyModel * Adds more tests, adds normals to ML optimizer * Adds more tests, adds normals to ML optimizer * Rolls back formatting, sorry * Review day 1 * Fixes closest * Review stage + cleanup * Adds const correctness to variables * Corrects a silly mistake * Normalize direction after optimizemodelcoeffs * Format review
1 parent e4ce309 commit a541c5c

File tree

5 files changed

+2169
-499
lines changed

5 files changed

+2169
-499
lines changed

sample_consensus/CMakeLists.txt

+3
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ set(srcs
2727
src/sac_model_registration.cpp
2828
src/sac_model_sphere.cpp
2929
src/sac_model_ellipse3d.cpp
30+
src/sac_model_torus.cpp
3031
)
3132

3233
set(incs
@@ -58,6 +59,7 @@ set(incs
5859
"include/pcl/${SUBSYS_NAME}/sac_model_registration_2d.h"
5960
"include/pcl/${SUBSYS_NAME}/sac_model_sphere.h"
6061
"include/pcl/${SUBSYS_NAME}/sac_model_ellipse3d.h"
62+
"include/pcl/${SUBSYS_NAME}/sac_model_torus.h"
6163
)
6264

6365
set(impl_incs
@@ -85,6 +87,7 @@ set(impl_incs
8587
"include/pcl/${SUBSYS_NAME}/impl/sac_model_registration_2d.hpp"
8688
"include/pcl/${SUBSYS_NAME}/impl/sac_model_sphere.hpp"
8789
"include/pcl/${SUBSYS_NAME}/impl/sac_model_ellipse3d.hpp"
90+
"include/pcl/${SUBSYS_NAME}/impl/sac_model_torus.hpp"
8891
)
8992

9093
set(LIB_NAME "pcl_${SUBSYS_NAME}")

0 commit comments

Comments
 (0)