Improve SSE/AVX detection on arm and when cross-compiling #6264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change check_cxx_source_runs to check_cxx_source_compiles because running the code does not provide any additional information, and is a problem when cross-compiling. When we know that we compile for arm, we set PCL_ENABLE_SSE and PCL_ENABLE_AVX to OFF to skip the checks completely.
mvieth
added
module: cmake
changelog: fix
larshg
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change check_cxx_source_runs to check_cxx_source_compiles because running the code does not provide any additional information, and is a problem when cross-compiling. When we know that we compile for arm, we set PCL_ENABLE_SSE and PCL_ENABLE_AVX to OFF to skip the checks completely.
Follow-up on #6261
Fixes #5843
Fixes #6151