-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/remove sudo #185
Merged
Merged
Feat/remove sudo #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try-runtime-cli input: try-runtime \
--runtime target/release/wbuild/polimec-base-runtime/polimec_base_runtime.compact.compressed.wasm \
on-runtime-upgrade \
live --uri wss://rpc.polimec.org:443 try-runtime-cli output: [2024-03-11T14:27:24Z INFO try-runtime::cli] Original runtime [Name: RuntimeString::Owned("polimec-mainnet")] [Version: 5000] [Code hash: 0x0162...c6f6]
[2024-03-11T14:27:24Z INFO try-runtime::cli] New runtime [Name: RuntimeString::Owned("polimec-mainnet")] [Version: 5005] [Code hash: 0xaf64...35a3]
[2024-03-11T14:27:24Z INFO try-runtime::cli] 🚀 Speed up your workflow by using snapshots instead of live state. See `try-runtime create-snapshot --help`.
[2024-03-11T14:27:24Z INFO try_runtime_core::commands::on_runtime_upgrade] 🔬 Running TryRuntime_on_runtime_upgrade with checks: PreAndPost
[2024-03-11T14:27:24Z INFO frame_support::migrations] Found Sudo keys pre-removal 👀
[2024-03-11T14:27:24Z INFO frame_support::migrations] Removed 2 Sudo keys 🧹
[2024-03-11T14:27:24Z INFO frame_support::migrations] No Sudo keys found post-removal 🎉
[2024-03-11T14:27:24Z INFO runtime::frame-support] ⚠️ PolkadotXcm declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`
[2024-03-11T14:27:24Z INFO try_runtime_core::commands::on_runtime_upgrade] 🔬 TryRuntime_on_runtime_upgrade succeeded! Running it again without checks for weight measurements.
[2024-03-11T14:27:24Z INFO frame_support::migrations] Removed 2 Sudo keys 🧹
[2024-03-11T14:27:24Z INFO runtime::frame-support] ⚠️ PolkadotXcm declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`
[2024-03-11T14:27:24Z INFO try_runtime_core::commands::on_runtime_upgrade] 🔬 Running TryRuntime_on_runtime_upgrade again to check idempotency: PreAndPost
[2024-03-11T14:27:24Z WARN frame_support::migrations] Migration RemovePallet<Sudo> can be removed (no keys found pre-removal).
[2024-03-11T14:27:24Z INFO frame_support::migrations] Removed 2 Sudo keys 🧹
[2024-03-11T14:27:24Z INFO frame_support::migrations] No Sudo keys found post-removal 🎉
[2024-03-11T14:27:24Z INFO runtime::frame-support] ⚠️ PolkadotXcm declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`
[2024-03-11T14:27:24Z INFO try-runtime::cli] PoV size (zstd-compressed compact proof): 635 B. For parachains, it's your responsibility to verify that a PoV of this size fits within any relaychain constraints.
[2024-03-11T14:27:24Z INFO try-runtime::cli] Consumed ref_time: 0s (0.00% of max 0.5s)
[2024-03-11T14:27:24Z INFO try-runtime::cli] ✅ No weight safety issues detected. Please note this does not guarantee a successful runtime upgrade. Always test your runtime upgrade with recent state, and ensure that the weight usage of your migrations will not drastically differ between testing and actual on-chain execution. |
vstam1
approved these changes
Mar 11, 2024
JuaniRios
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Using a json file for the live polimec genesis seems to be the way to do it if we look at polkadot's implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sudo
pallet.BaseCallFilter
.Why?
It's about time.
How?
Sudo
pallet from theconstruct_runtime!
macro.RemovePallet
migration to remove all the keys (2) in the DB.Anything Else?
spec_version
to match Rolimec.