Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plmc 467 return deposits to issuer on project fail #195

Conversation

JuaniRios
Copy link
Contributor

What?

  • We charge the issuer PLMC for the ct account of the ct-treasury, the metadata deposit of the ct, and the ED of the escrow.
    • If the project fails, then no CT is created, therefore we can return the deposits associated with it.
    • The escrow still needs to live since it holds users' funds that need to be returned.

Why?

  • We weren't returning them before

How?

  • In the same place we were creating the CT on project success, we return CT deposits on project fail.
    • This is the function that started the Cleaner.

Testing?

  • New function called creation_deposits_returned_on_funding_fail

@JuaniRios JuaniRios self-assigned this Mar 18, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 March 18, 2024 13:47
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably only metadata_deposit return is necessary after the ct_deposit removal. Could also probably choose to make that free as well as we limit the amount of tokens being created

@JuaniRios
Copy link
Contributor Author

Probably only metadata_deposit return is necessary after the ct_deposit removal. Could also probably choose to make that free as well as we limit the amount of tokens being created

exactly. This PR probably can be dropped after the ct_deposit removal

@vstam1 vstam1 closed this Mar 20, 2024
@JuaniRios JuaniRios deleted the feature/plmc-467-return-deposits-to-issuer-on-project-fail branch March 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants