Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to stable2412-2 #470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dastansam
Copy link

@dastansam dastansam commented Mar 14, 2025

What?

closes #446

Tasks

  • Review release notes for stable2412 for breaking changes. Also check the release notes of the versions before (with a focus on stable2409 and 1.14.0).
  • Update Polkadot SDK dependencies to stable2412.
  • Update ORML dependencies to the according version.
  • Test node and runtime compatibility (e.g., compile-time errors, runtime APIs, storage migrations).
  • Audit custom pallets for deprecated or changed SDK interfaces.
  • Update benchmarks (if applicable) for weight calculations.

Additional Context

  • The Treasury::propose_spend(...) integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced by Treasury::sped_local(...). We can ignore these tests for now and re-add them in a later PR.

Why?

Release analysis posts here.

Some notable PRs:

How?

Testing?

  • Pallet Unit Testing (e.g. cargo t -p pallet-funding)
  • Integration Tests (e.g. cargo t -p integration-tests)
  • Try Runtime CLI, to test if we have to run any migration in this upgrade.

Screenshots (optional)

Syncing with mainnet `polimec` Screenshot 2025-02-06 at 1 16 29

@dastansam dastansam mentioned this pull request Mar 14, 2025
9 tasks
@dastansam dastansam requested a review from lrazovic March 14, 2025 07:41
@dastansam dastansam self-assigned this Mar 14, 2025
@dastansam dastansam marked this pull request as ready for review March 14, 2025 07:41
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, but overall looks quite good! I'm just a bit worried about this entire XCMv5, maybe a bit "premature" since AH is still not using it. Do you think it is a good idea to proceed with the update? Can we stick to XCMv4 for now and move to v5 after AH also migrates to v5?

@dastansam dastansam force-pushed the 03-14-upgrade_to_stable2412-2 branch 2 times, most recently from 891799a to d116e92 Compare March 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Polkadot SDK from 1.13.0 to stable2412
2 participants