-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to stable2412-2 #470
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits, but overall looks quite good! I'm just a bit worried about this entire XCMv5, maybe a bit "premature" since AH is still not using it. Do you think it is a good idea to proceed with the update? Can we stick to XCMv4 for now and move to v5 after AH also migrates to v5?
891799a
to
d116e92
Compare
d116e92
to
2828880
Compare
What?
closes #446
Tasks
stable2409
and1.14.0
).stable2412
.Additional Context
Treasury::propose_spend(...)
integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced byTreasury::sped_local(...)
. We can ignore these tests for now and re-add them in a later PR.Why?
Release analysis posts here.
Some notable PRs:
SignedExtra
with newTransactionExtension
. This requires us to reimplement the customCheckNonce
as a follow up PR - FRAME: ReintroduceTransactionExtension
as a replacement forSignedExtension
paritytech/polkadot-sdk#3685latest
, sov4
xcm types are replaced withv5
- XCM v5 paritytech/polkadot-sdk#4826 -xcm-fee-payment-runtime-api
module into the newxcm-runtime-apis
- [xcm] runtime api for LocationToAccount conversions paritytech/polkadot-sdk#4857sp-std
dependency, replace withalloc
orcore
How?
Testing?
cargo t -p pallet-funding
)cargo t -p integration-tests
)Screenshots (optional)
Syncing with mainnet `polimec`