Prepare pallets for async backing #471
Open
+171
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 14, 2025
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (03/14/25)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
a021c92 to
e07c1a9
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
e07c1a9 to
cbc803c
Compare
dastansam
force-pushed
the
03-14-upgrade_to_stable2412-2
branch
from
0ca5002 to
891799a
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
cbc803c to
4317213
Compare
dastansam
force-pushed
the
03-14-upgrade_to_stable2412-2
branch
from
891799a to
d116e92
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
4317213 to
8c9017b
Compare
dastansam
force-pushed
the
03-14-upgrade_to_stable2412-2
branch
from
d116e92 to
2828880
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
8c9017b to
d1e02ed
Compare
This was referenced Mar 21, 2025
lrazovic
approved these changes
Mar 25, 2025
|
|
||
| #[frame_support::pallet] | ||
| pub mod pallet { | ||
| use super::BlockNumberFor; |
There was a problem hiding this comment.
Isn't this also part of the use super::*; two lines below?
| @@ -115,6 +115,9 @@ pub mod pallet { | |||
| /// The Whitelisted policy for the dispenser. Users' credentials should have the same | |||
| /// policy to be eligible for token dispensing. | |||
| type WhitelistedPolicy: Get<Cid>; | |||
|
|
|||
| // /// Block number provider. | |||
| // type BlockNumberProvider: BlockNumberProvider<BlockNumber = BlockNumberFor<Self>>; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Introduces
BlockNumberProvidertype for palletsWhy?
So that we can use a more reliable, consistent notion of block number, since with async backing system block number becomes nondeterministic
How?
Relay chain's block number is used where possible, i.e funding, linear-release, and we rely on system block number in other cases
Testing?
Changes were made to
Instantiatorso that it works for both integration and unit tests, since now integration tests Runtime uses relay chain's block number instead of chain'sScreenshots (optional)
Anything Else?
#469