Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to stable2412-2 #462

Closed
wants to merge 1 commit into from
Closed

Upgrade to stable2412-2 #462

wants to merge 1 commit into from

Conversation

dastansam
Copy link

@dastansam dastansam commented Feb 26, 2025

What?

closes #446

Tasks

  • Review release notes for stable2412 for breaking changes. Also check the release notes of the versions before (with a focus on stable2409 and 1.14.0).
  • Update Polkadot SDK dependencies to stable2412.
  • Update ORML dependencies to the according version.
  • Test node and runtime compatibility (e.g., compile-time errors, runtime APIs, storage migrations).
  • Audit custom pallets for deprecated or changed SDK interfaces.
  • Update benchmarks (if applicable) for weight calculations.

Additional Context

  • The Treasury::propose_spend(...) integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced by Treasury::sped_local(...). We can ignore these tests for now and re-add them in a later PR.

Why?

Release analysis posts here.

Some notable PRs:

How?

Testing?

  • Pallet Unit Testing (e.g. cargo t -p pallet-funding)
  • Integration Tests (e.g. cargo t -p integration-tests)
  • Try Runtime CLI, to test if we have to run any migration in this upgrade.

Screenshots (optional)

Syncing with mainnet `polimec` Screenshot 2025-02-06 at 1 16 29

@dastansam dastansam marked this pull request as ready for review February 26, 2025 17:00
@dastansam dastansam mentioned this pull request Feb 26, 2025
9 tasks
@dastansam
Copy link
Author

will remove identity pallet and add a migration now

Copy link

graphite-app bot commented Feb 26, 2025

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (02/26/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@lrazovic lrazovic force-pushed the 02-20-replace_weth_with_eth branch 2 times, most recently from 129619f to c14ed54 Compare March 5, 2025 10:00
Base automatically changed from 02-20-replace_weth_with_eth to main March 5, 2025 10:02
@dastansam dastansam force-pushed the upgrade-stable-2412-2 branch from ccfd0c0 to 6ee8df3 Compare March 5, 2025 20:05
@dastansam
Copy link
Author

resolved conflicts and squashed all commits into one @lrazovic

@dastansam
Copy link
Author

closed in favor of #470

@dastansam dastansam closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Polkadot SDK from 1.13.0 to stable2412
1 participant