nix: improve dev workflow #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves PostgREST#5. This is done by avoiding building the postgres extension inside the nix derivation. Instead we build it with `make` on the current directory and install it on postgres using the upcoming postgres `extension_control_path` GUC. This is taken from the patch on https://www.postgresql.org/message-id/flat/E7C7BFFB-8857-48D4-A71F-88B359FADCFD%40justatheory.com and backpatched to postgres 12, 13, 14, 15 and 16, Thanks to this, it's now possible to do watch commands: ``` nxpg-watch nxpg-16 nxpg-build (rebuilds when changing sources) nxpg-watch nxpg-13 nxpg-tmp nxpg-test (runs tests when changing sources) ``` Future improvements: * Makes possible to enable code coverage, since the `.gcno` files will live outside the nix store. * It's wasteful to rebuild the patched pgs everytime, later on this `nxpg` could live in another repo and benefit from Nix caching. Additionally: * removes clean_generated in favor of builtin EXTRA_CLEAN * Don't hardcode sources in Makefile * Update github action
steve-chavez
force-pushed
the
fix-workflow
branch
from
69671d8 to
91e2c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #5.
This is done by avoiding building the postgres extension inside the nix derivation. Instead we build it with
makeon the current directory and install it on postgres using the upcoming postgresextension_control_pathGUC.This is taken from the patch on
https://www.postgresql.org/message-id/flat/E7C7BFFB-8857-48D4-A71F-88B359FADCFD%40justatheory.com and backpatched to postgres 12, 13, 14, 15 and 16,
Thanks to this, it's now possible to do watch commands:
Future improvements:
Makes possible to enable code coverage, since the
.gcnofiles will live outside the nix store.It's wasteful to rebuild the patched pgs everytime, later on this
nxpgcould live in another repo and benefit from Nix caching.Additionally:
removes clean_generated in favor of builtin EXTRA_CLEAN
Don't hardcode sources in Makefile
Update github action