Overhaul linting, formatting, and testing infrastructure #5190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
lint-overhaul
branch
from
58f1dd0 to
c82afed
Compare
andyleejordan
force-pushed
the
lint-overhaul
branch
from
c82afed to
fccf1f6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR completely overhauls our linting, formatting, and testing infrastructure. It replaces legacy import and configuration patterns with modern TypeScript type imports and updated configuration files, while also revising workspace settings and dependency versions.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/logging.ts | Modernized logger initialization using nullish assignment and updated imports |
| src/features/* | Updated type imports and removed eslint-disable comments for empty interfaces |
| src/extension.ts | Adjusted import types and refined inline comments |
| pwsh-extension-dev.code-workspace | Revised workspace settings with updated file patterns and new extension recommendations |
| package.json, eslint.config.mjs, etc. | Updated dependency versions and overhauled configuration to support new standards |
Comments suppressed due to low confidence (2)
src/logging.ts:143
- The use of the nullish assignment operator (??=) is concise; ensure that the target environment and TypeScript version fully support this syntax.
this._channel ??= window.createOutputChannel(this.channelName, {log: true});
pwsh-extension-dev.code-workspace:314
- The new 'outFiles' pattern is more restrictive; make sure it matches all emitted JavaScript files required for proper source map support.
"${workspaceFolder:Client}/dist/*.js"
JustinGrote
approved these changes
May 15, 2025
| "@vscode/vsce": "^3.3.0", | ||
| "esbuild": "^0.25.1" | ||
| "@vscode/vsce": "^3.3.2", | ||
| "esbuild": "^0.25.4" | ||
| }, | ||
| "optionalDependencies": { |
There was a problem hiding this comment.
We probably should document somewhere why optionalDependencies vs devdependencies
There was a problem hiding this comment.
I'm really hoping it changes when I get back to trying #5063
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5188 with a whole overhaul of our linting, formatting, and testing infrastructure.