Migrate to pyproject.toml
#17116
Merged
Migrate to pyproject.toml
#17116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
added
the
development
github-actions
bot
added
the
upstream dependency
zzstoatzz
force-pushed
the
pyproject-v2
branch
from
a176578 to
adb5a9b
Compare
CodSpeed Performance ReportMerging #17116 will improve performances by 10.05%Comparing Summary
Benchmarks breakdown
|
zzstoatzz
force-pushed
the
pyproject-v2
branch
2 times, most recently
from
07430d3 to
b933628
Compare
zzstoatzz
force-pushed
the
pyproject-v2
branch
3 times, most recently
from
05f4e92 to
4609191
Compare
zzstoatzz
requested review from
aaazzam,
chrisguidry,
cicdw,
desertaxle and
kevingrismore
as code owners
desertaxle
requested review from
daniel-prefect and
seanpwlms
as code owners
zzstoatzz
commented
Feb 14, 2025
| @@ -31,8 +31,8 @@ def _read_toml_file(path: Path) -> dict[str, Any]: | |||
| """use ttl cache to cache toml files""" | |||
| modified_time = path.stat().st_mtime | |||
| cache_key = f"toml_file:{path}:{modified_time}" | |||
| if cache_key in _file_cache: | |||
| return _file_cache[cache_key] | |||
| if value := _file_cache.get(cache_key): | |||
There was a problem hiding this comment.
eliminates a possible key missing error from the duplicate check
zzstoatzz
commented
Feb 14, 2025
Comment on lines
+51
to
+93
| client = [ | ||
| # Client dependencies | ||
| # If you modify this list, make the same modification in client/pyproject.toml | ||
| "anyio>=4.4.0,<5.0.0", | ||
| "asgi-lifespan>=1.0,<3.0", | ||
| "cachetools>=5.3,<6.0", | ||
| "cloudpickle>=2.0,<4.0", | ||
| "coolname>=1.0.4,<3.0.0", | ||
| "croniter>=1.0.12,<7.0.0", | ||
| "exceptiongroup>=1.0.0", | ||
| "fastapi>=0.111.0,<1.0.0", | ||
| "fsspec>=2022.5.0", | ||
| "graphviz>=0.20.1", | ||
| "griffe>=0.49.0,<2.0.0", | ||
| "httpcore>=1.0.5,<2.0.0", | ||
| "httpx[http2]>=0.23,!=0.23.2", | ||
| "importlib_metadata>=4.4;python_version<'3.10'", | ||
| "jsonpatch>=1.32,<2.0", | ||
| "jsonschema>=4.0.0,<5.0.0", | ||
| "opentelemetry-api>=1.27.0,<2.0.0", | ||
| "orjson>=3.7,<4.0", | ||
| "packaging>=21.3,<24.3", | ||
| "pathspec>=0.8.0", | ||
| "pendulum>=3.0.0,<4", | ||
| "prometheus-client>=0.20.0", | ||
| "pydantic>=2.9,<3.0.0,!=2.10.0", | ||
| "pydantic_core>=2.12.0,<3.0.0", | ||
| "pydantic_extra_types>=2.8.2,<3.0.0", | ||
| "pydantic_settings>2.2.1", | ||
| "python-dateutil>=2.8.2,<3.0.0", | ||
| "python-slugify>=5.0,<9.0", | ||
| "python-socks[asyncio]>=2.5.3,<3.0", | ||
| "pyyaml>=5.4.1,<7.0.0", | ||
| "rfc3339-validator>=0.1.4,<0.2.0", | ||
| "rich>=11.0,<14.0", | ||
| "ruamel.yaml>=0.17.0", | ||
| "sniffio>=1.3.0,<2.0.0", | ||
| "toml>=0.10.0", | ||
| "typing_extensions>=4.5.0,<5.0.0", | ||
| "ujson>=5.8.0,<6.0.0", | ||
| "uvicorn>=0.14.0,!=0.29.0", | ||
| "websockets>=10.4,<14.0", | ||
| ] |
There was a problem hiding this comment.
as previously in requirements-client.txt
zzstoatzz
commented
Feb 14, 2025
Comment on lines
+220
to
+240
| [tool.hatch.version] | ||
| source = "versioningit" | ||
|
|
||
| [tool.versioningit.vcs] | ||
| match = ["[0-9]*.[0-9]*.[0-9]*", "[0-9]*.[0-9]*.[0-9]*.dev[0-9]*"] | ||
| default-tag = "0.0.0" | ||
|
|
||
| [tool.versioningit.write] | ||
| method = { module = "write_build_info", value = "write_build_info", module-dir = "tools" } | ||
| path = "src/prefect/_build_info.py" | ||
|
|
||
| [tool.versioningit.format] | ||
| distance = "{base_version}+{distance}.{vcs}{rev}" | ||
| dirty = "{base_version}+{distance}.{vcs}{rev}.dirty" | ||
| distance-dirty = "{base_version}+{distance}.{vcs}{rev}.dirty" | ||
|
|
||
| [tool.hatch.build] | ||
| artifacts = ["src/prefect/_build_info.py"] | ||
|
|
||
| [tool.hatch.build.targets.sdist] | ||
| include = ["/src/prefect", "/README.md", "/LICENSE", "/pyproject.toml"] |
There was a problem hiding this comment.
important build config
zzstoatzz
commented
Feb 18, 2025
try again
try again try again
zzstoatzz
force-pushed
the
pyproject-v2
branch
from
7f76895 to
88aaee9
Compare
cicdw
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates our library configuration from
setup.cfgandsetup.pytopyproject.toml.As part of this migration, we were also able to migrate our build system from
setuptoolstohatchling, which has proven to be more ergonomic so far. This PR also moves us away from usingversioneertoversioningitinstead, which is more customizable and integrates nicely withhatchling.Moving to
pyproject.tomlallow us to greatly improve the developer experience by enabling newuvfeatures. Developers now can runuv syncto automatically create a virtual environment and install the necessary dependencies. The use ofuv syncalso simplifies our CI workflows. We set up local sources for all integrations, which allow developers to easily install a local editable version ofprefectwhen working on an integration by runninguv syncin an integrations sub-directory.The contribution docs have also been updated to reflect the new capabilities that
uvoffers for our project.Closes #8007
Closes #17124