Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to pyproject.toml #17116

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

migrate to pyproject.toml #17116

wants to merge 12 commits into from
+452 −1,240

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Feb 12, 2025 •
edited
Loading

closes #8007 #17124

@zzstoatzz zzstoatzz changed the title no prefect 4 yet working on pyproject.toml Feb 12, 2025
@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Feb 12, 2025
@github-actions github-actions bot added the upstream dependency An upstream issue caused by a bug in one of our dependencies label Feb 12, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #17116 will degrade performances by 37.75%

Comparing pyproject-v2 (b933628) with main (61ea331)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ bench_import_prefect_flow 1.7 s 2.8 s -37.75%

@zzstoatzz zzstoatzz force-pushed the pyproject-v2 branch 2 times, most recently from 07430d3 to b933628 Compare February 12, 2025 22:16
@github-actions github-actions bot added the bug Something isn't working label Feb 13, 2025
@zzstoatzz zzstoatzz changed the title working on pyproject.toml migrate to pyproject.toml Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam will be requested when the pull request is marked ready for review aaazzam is a code owner

@kevingrismore kevingrismore Awaiting requested review from kevingrismore kevingrismore will be requested when the pull request is marked ready for review kevingrismore is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw will be requested when the pull request is marked ready for review cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle will be requested when the pull request is marked ready for review desertaxle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working development Tech debt, refactors, CI, tests, and other related work. upstream dependency An upstream issue caused by a bug in one of our dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from setup.cfg to pyproject.toml
2 participants
@zzstoatzz @desertaxle