Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v2 libraries and small bug fixes and refactors #10

Merged
merged 60 commits into from
Feb 17, 2025

Conversation

jonbarrow
Copy link
Member

Draft since lots of things are changing still, but wanted to get this into more peoples hands

PR brings server up to date with the latest nex-go PR

@jonbarrow jonbarrow marked this pull request as draft November 12, 2023 11:53
@jonbarrow jonbarrow marked this pull request as ready for review April 8, 2024 12:54
@jonbarrow jonbarrow changed the base branch from master to dev April 8, 2024 12:55
@jonbarrow jonbarrow changed the title New nex-go Update to v2 libraries and small bug fixes and refactors Apr 8, 2024
@jonbarrow
Copy link
Member Author

Cemu seems to have some some DC issues, but I'm unsure if this is an us issue or a Cemu issue. Cemu would disconnect every few seconds and reconnect when in the friends applet

That said, I was connected via real hardware for around 30 minutes with no issue. Since real hardware is our main target, I'm fine with this

@DaniElectra
Copy link
Member

Are there any other Scan error checks that we would want to ignore for now?

jonbarrow and others added 20 commits May 20, 2024 17:16
Although the UPDATE section of the query was updated properly, the
INSERT ection was unmodified, which causes type conflicts when trying to
update the user's Mii. Update the INSERT query properly.
Initializing the server accounts in their own thread (e.g. the
authentication and secure servers) can cause a race condition where the
secure account hasn't been set up yet when authentication configures
`ticket-granting`, causing sometimes crashes on startup.

This has happened on production causing unnecesary restarts. To fix
this, initialize the accounts on the `init` function to ensure they will
always be accessible when needed.
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ jonbarrow
✅ imora7024
✅ MatthewL246
✅ DaniElectra
✅ mrjvs
❌ wolfendale
You have signed the CLA already but the status is still pending? Let us recheck it.

@jonbarrow jonbarrow marked this pull request as draft February 16, 2025 04:40
@jonbarrow
Copy link
Member Author

Marked as draft again since so much has changed, and this is largely untested right now. Will need someone like @hauntii to verify the 3DS parts as he's the one who designed them

Dockerfile Outdated
FROM alpine:3.17 as runner
WORKDIR /build
# * Building the application
FROM golang:1.22-alpine3.20 AS build
Copy link
Member

@binaryoverload binaryoverload Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is currently failing due to an outdated version of Go in Docker:

go: go.mod requires go >= 1.23.0 (running go 1.22.12; GOTOOLCHAIN=local)

Please update this Dockerfile to use 1.23

Suggested change
FROM golang:1.22-alpine3.20 AS build
FROM golang:1.23.6-alpine AS build

@jonbarrow jonbarrow marked this pull request as ready for review February 17, 2025 00:16
@jonbarrow jonbarrow merged commit af5c5f1 into dev Feb 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants