Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base image to support nvcc out of the box #74

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

JannikSt
Copy link
Member

the current docker image does not seem to work on most of the machines without adjusting the underlying machine (which is not very useful for a decentralized use-case).

with the current image version primeintellect/genesys:commit-bc10edd the following error appears on the debug.conf:

/bin/sh: 1: /usr/local/cuda/bin/nvcc: not found

the current change solves this issue. I have pushed a sample to: jannikstprime/genesys:latest

@JannikSt JannikSt requested a review from samsja February 28, 2025 16:05
Copy link
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Indeed we need devel for all the custom kernel in sglang

@samsja samsja merged commit 32e8ccc into main Feb 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants