Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grammar changes and apply other fixes across various posts #248

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

friendly-rabbit-35
Copy link
Contributor

I encountered some grammar mistakes and other things that stuck out to me while reading some posts for #246, so this PR aims to correct them and generally enhance readability of these pages.

Notable changes:

  • Android Tips
    • Reword section on /e/ OS for better flow of ideas
    • Fix broken link to PrivSec article on choosing an Android-based OS
    • Change "the remote attestation service" link to a more specific one
    • Fix Aurora Store link
    • Change the "SMS OTP" link so that it points to the appropriate section
    • Update the instructions for disabling telemetry in Google Messages (tested on version 202405028_00_RC01)
  • Make changes to grammar and wording across multiple pages

Signed-off-by: friendly-rabbit-35 <169707731+friendly-rabbit-35@users.noreply.github.com>
Signed-off-by: friendly-rabbit-35 <169707731+friendly-rabbit-35@users.noreply.github.com>
Signed-off-by: friendly-rabbit-35 <169707731+friendly-rabbit-35@users.noreply.github.com>
Signed-off-by: friendly-rabbit-35 <169707731+friendly-rabbit-35@users.noreply.github.com>
Signed-off-by: friendly-rabbit-35 <169707731+friendly-rabbit-35@users.noreply.github.com>
Signed-off-by: friendly-rabbit-35 <169707731+friendly-rabbit-35@users.noreply.github.com>
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for privsec-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e411741
🔍 Latest deploy log https://app.netlify.com/sites/privsec-dev/deploys/6668695487a7c80008f9f014
😎 Deploy Preview https://deploy-preview-248--privsec-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@friendly-rabbit-35 friendly-rabbit-35 changed the title Make grammar changes and other fixes across various posts Make grammar changes and apply other fixes across various posts Jun 11, 2024
@TommyTran732 TommyTran732 merged commit 4783e25 into PrivSec-dev:main Jun 11, 2024
4 checks passed
@friendly-rabbit-35 friendly-rabbit-35 deleted the clean-up-pages branch June 12, 2024 01:02
@wj25czxj47bu6q wj25czxj47bu6q added the [c] cleanup Minor fixes and tweaks (spelling errors, dead links, etc.) label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[c] cleanup Minor fixes and tweaks (spelling errors, dead links, etc.)
Development

Successfully merging this pull request may close these issues.

3 participants