Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switch sounds #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix switch sounds #32

wants to merge 1 commit into from

Conversation

BroBeansCPG
Copy link
Member

as title

@Aaren882
Copy link

It should be "z/htf/hatchet_vxf_interaction"

Example "z/htf/hatchet_vxf_interaction/sounds/switch.wss"

@BroBeansCPG
Copy link
Member Author

It should be "z/htf/hatchet_vxf_interaction"

Example "z/htf/hatchet_vxf_interaction/sounds/switch.wss"

prefixes be weird,

I think because it's "/hatchet_vxf_interaction" it grabs the prefix itself..

The alternative errors for me funnily enough.

Tested in-game though, clicks are present and no errors

@Aaren882
Copy link

Oh that's okay then
I didn't expect that lol

@jonpas
Copy link
Contributor

jonpas commented Jul 17, 2023

This is redundant as it's modifying an old version from Workshop recovery efforts. See #31.

@BroBeansCPG
Copy link
Member Author

This is redundant as it's modifying an old version from Workshop recovery efforts. See #31.

remind me to check this out, wasn't sure if you used the workshop vers or the new stuff

@jonpas
Copy link
Contributor

jonpas commented Jul 17, 2023

That PR keeps the new stuff and removes current Workshop version. A tag can be created for reference, but shouldn't be kept, as new version is way ahead, including a lot of the work by @BrettMayson (which is still not used by the H-60 sadly).

@BroBeansCPG
Copy link
Member Author

Aware, unfortunately a lot of his changes never made it to the workshop version. There’s a lot of goodies that I’m keen to see come through though. I’ll check this out tomorrow and see how it goes & look at merging

@BroBeansCPG BroBeansCPG changed the base branch from main to legacy December 15, 2024 06:32
Base automatically changed from legacy to main December 16, 2024 10:39
@Riverman02
Copy link

Is this good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants