-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumpy Numpy version limit to include 2.x only + Pytorch 2.6 #8309
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericspod I would suggest updating the automated workflow so that when it tests older torch versions (pre-2.3.0 which don’t have numpy 2 support), to python -m pip install numpy<2
just before the torch install linked below. This should keep this numpy 1 version as torch is installed and as well as when MONAI gets installed afterwards. With this PR’s change, having numpy<2 already installed with an older torch is fine and will meet the install_requires for MONAI when it goes to get installed and won’t force the upgrade of them.
MONAI/.github/workflows/pythonapp-min.yml
Line 157 in df1ba5d
python -m pip install torch==${{ matrix.pytorch-version }} |
Thanks for the suggestion, that would fix this PR however we wouldn't resolve the version issue during installation. Users would still need to pre-install Numpy like this. This PR was more an experiment to see what version updates we can do and where the pain points were. We're still discussing the version policy which will change what we do here as well, and hopefully resolve this Numpy issue. |
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
for more information, see https://pre-commit.ci
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Partially addresses #8303.
Description
This changes the maximum Numpy version to be below 3.0 for testing with 2.x compatibility. This appears to be resolved with newer versions of dependencies. This will also include fixes for Pytorch 2.6 mostly relating to
torch.load
usage.Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.